[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec utils.c, 1.173, 1.174 avcodec.h, 1.455, 1.456

[Michael Niedermayer]

Hi

On Tue, Feb 21, 2006 at 11:57:11PM +0100, Alex Beregszaszi wrote:
> Hi,
> 
> > > @@ -266,11 +266,14 @@
> > >  };
> > >  
> > >  /* currently unused, may be used if 24/32 bits samples ever
> > >  supported */
> > > +/* all in native endian */
> > >  enum SampleFormat {
> > > -    SAMPLE_FMT_S16 = 0,         ///< signed 16 bits
> > > +    SAMPLT_FMT_NONE = -1,
> > > +    SAMPLE_FMT_U8,              ///< unsigned 8 bits
> > > +    SAMPLE_FMT_S16,             ///< signed 16 bits
> > > +    SAMPLE_FMT_S24,             ///< signed 24 bits
> > >      SAMPLE_FMT_S32,             ///< signed 32 bits
> > >      SAMPLE_FMT_FLT,             ///< float
> > > -    SAMPLE_FMT_DBL,             ///< double
> > >  };
> > 
> > I guess this breaks the ABI (and API as you remove SAMPLE_FMT_DBL)
> > so this certainly deserve a version number increase.
> 
> It was never used. Michael, can you comment?

i dont see any sense in changing the version number when not yet working
and as "unused" marked code is changed

but there are a few things iam not entirely happy with
* S16 was 0 and is 1 now
* SAMPLT_FMT_NONE is -1, somehow i think if we do change S16s value NONE 
  should be 0
* i see little sense in S24 and U8 currently at least, no codec will use
  S24 internally, and for raw we need many more formats, S24 in 
  native endian is also not good at all as theres no native S24 on most
  CPUs

[...]
-- 
Michael