[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec qdm2.c,1.7,1.8

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Tue, Jan 31, 2006 at 11:02:03PM +0100, Alexander Strasser wrote:
>> M?ns Rullg?rd CVS wrote:
>> > 
>> > Modified Files:
>> > 	qdm2.c 
>> > Log Message:
>> > add static keyword to some functions
>> > patch by Dieter <freebsd at sopwith solgatos com>
>> > 
>> > --- qdm2.c	14 Jan 2006 15:00:10 -0000	1.7
>> > +++ qdm2.c	30 Jan 2006 23:41:27 -0000	1.8
>> > @@ -230,7 +230,7 @@
>> >  static MPA_INT mpa_window[512] __attribute__((aligned(16)));
>> >  
>> >  
>> > -static void softclip_table_init() {
>> > +static void softclip_table_init(void) {
>> 
>>   I somehow dislike this kind of changes. What does the standard say
>> about this?

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments.  What don't you
like about it?

> Not to mention that the change does not fit the commit message..

My bad.

> Mans, did you maybe mix up the patches?  (No wonder, there were several
> dozen..)

Should have read more carefully.  There were as you say dozens of
them, all purporting to be portability fixes related to 64-bit
hardware while in fact none of them were.  I tried to sort them into
proper categories, but this one seems to have misfiled.

-- 
M?ns Rullg?rd
mru at inprovide.com