[Ffmpeg-cvslog] r7234 - trunk/libavformat/utils.c

Baptiste Coudurier baptiste.coudurier
Wed Dec 6 18:08:06 CET 2006


M?ns Rullg?rd wrote:
> Baptiste Coudurier said:
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Wed, Dec 06, 2006 at 04:53:29PM +0100, Reimar D?ffinger wrote:
>>>> Hello,
>>>> On Wed, Dec 06, 2006 at 04:46:12PM +0100, bcoudurier wrote:
>>>>> -    pkt->pts &= pts_mask;
>>>>> -    pkt->dts &= pts_mask;
>>>>> +    if( pkt->pts != AV_NOPTS_VALUE ) {
>>>>> +        pkt->pts &= pts_mask;
>>>>> +    }
>>>>> +    if( pkt->dts != AV_NOPTS_VALUE ) {
>>>>> +        pkt->dts &= pts_mask;
>>>>> +    }
>>>> Am I the only one who would have preferred this without the extra {}?
>>> no, but i thought it wasnt worth the complaint and resubmit and rereview
>>>
>> I would have also preferred. Should I clean, should we set a policy ?
> 
> I don't care about the extraneous braces {}, but *please* remove the spaces just
> inside the parens ().  I can't stand that style.
> 

Ok, done.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312




More information about the ffmpeg-cvslog mailing list