[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec ac3enc.c,1.29,1.30

Michael Niedermayer michaelni
Fri Apr 7 19:55:37 CEST 2006


Hi

On Fri, Apr 07, 2006 at 10:37:32AM -0700, Corey Hickey wrote:
> Roberto Togni wrote:
> >On Mon,  3 Apr 2006 02:51:11 +0200 (CEST)
> >corey at mplayerhq.hu (Corey Hickey CVS) wrote:
> >
> >>Update of /cvsroot/ffmpeg/ffmpeg/libavcodec
> >>In directory mail:/var2/tmp/cvs-serv17203/libavcodec
> >>
> >>Modified Files:
> >>	ac3enc.c 
> >>Log Message:
> >>AC3: support encoding fractional frame sizes
> >>
> >>Patch by Justin Ruggles, jruggle <<at>> earthlink <<dot>> net
> >>
> >>
> >>Index: ac3enc.c
> >>===================================================================
> >>RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/ac3enc.c,v
> >>retrieving revision 1.29
> >>retrieving revision 1.30
> >
> >This patch broke regression test
> >
> >-4292b4f8e930e386e9c00799197615e5 *./data/a-ac3.rm
> >-98203 ./data/a-ac3.rm
> >+3bc982921d6354be383ba37c1dbcf958 *./data/a-ac3.rm
> >+97983 ./data/a-ac3.rm
> >
> >Broken patch or just forgot to update regression test? Generated file
> >a-ac3.rm sounds ok.
> 
> I didn't realize it failed regression; now that the tests seem to be 
> working on amd64, I'll check patches even after Michael says they're ok.

sorry, i should have realized that the regression checksums might change


> 
> I would expect that the change is intended and the regresssion results 
> should be altered correspondingly. Justin, please comment. I'll patch 
> the results tomorrow if I don't hear otherwise.

the regression checksum change is probably ok, assuming of course that
its the same on x86 and x86-64

[...]

-- 
Michael

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is





More information about the ffmpeg-cvslog mailing list