[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec/i386 idct_mmx_xvid.c, NONE, 1.1 dsputil_mmx.c, 1.99, 1.100

[Michael Niedermayer]

Hi

On Sat, Sep 10, 2005 at 10:23:10PM +0200, Guillaume POIRIER wrote:
[...]
> > > > > On 9/10/05, Michael Niedermayer CVS <michael at mplayerhq.hu> wrote:
> > > > > > Update of /cvsroot/ffmpeg/ffmpeg/libavcodec/i386
> > > > > > In directory mail:/var2/tmp/cvs-serv23555/i386
> > > > > >
> > > > > > Modified Files:
> > > > > >         dsputil_mmx.c
> > > > > > Added Files:
> > > > > >         idct_mmx_xvid.c
> > > > > > Log Message:
> > > > > > xvids mmx&mmx2 idcts
> > > > > > needed to decode xvid without some minor artefacts
> > > > > > under #ifdef CONFIG_GPL of course
> > > > >
> > > > > Is that code enabled on AMD-64? I assume it's not, but one never know... :-)
> > > >
> > > > it should be but well, hmm i havnt really considered amd64 when porting it so
> > > > maybe it doesnt work, bugreports welcome
> > >
> > > Both are just as fast, but I can't see any visual difference (not that
> > > I saw that much of a difference between both implementations to begin
> > 
> > elaborate please, do you mean xvid looks better then lavc and old and new
> > lavc looks the same? or all 3 look the same?
> > and please ensure that the new idct is actually used at all (needs CONFIG_GPL
> > in config.h/mak) and latest lavc (with the change in h263dec.c)
> > maybe add a printf/avlog() into the idct to see if its really used ...
> 
> On the sample I tried, all version look the same. I'm still no too
> sure if the code is used as adding this:
>      if(s->codec_id == CODEC_ID_MPEG4 && s->xvid_build &&
> avctx->idct_algo == FF_IDCT_AUTO && (mm_flags & MM_MMX) &&
> !(s->flags&CODEC_FLAG_BITEXACT)){
>           avctx->idct_algo= FF_IDCT_XVIDMMX;
> +       av_log(s->avctx, AV_LOG_ERROR, "\n\nDecoding with xvid code \n\n");
>           avctx->coded_width= 0; // force reinit
>       }
> 
> doesn't print anything on the screen when I play an xvid file.
> 
> I also tried to comment out "#if defined(HAVE_MMX) &&
> defined(CONFIG_GPL)" and it still works but looks the same also.

hmm, which part of the if()/#if is false? that may be a bug which should be
fixed ...


> 
> I guess my eyes are not good enough...

try -vf eq2

[...]
-- 
Michael