[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec x264.c,1.10,1.11

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Wed, Nov 09, 2005 at 09:50:58AM +0100, M?ns Rullg?rd CVS wrote:
>> Update of /cvsroot/ffmpeg/ffmpeg/libavcodec
>> In directory mail:/var2/tmp/cvs-serv23251/libavcodec
>> 
>> Modified Files:
>> 	x264.c 
>> Log Message:
>> s/log2/av_log2/
>> patch by Steven M. Schultz <sms at 2bsd com>
> [...]
>> -            12 + 6 * log2((double) avctx->global_quality / FF_QP2LAMBDA);
>> +            12 + 6 * av_log2((double) avctx->global_quality / FF_QP2LAMBDA);
>
> umm, wtf? this is not correct av_log2() is int->int log2 is double->double

Reverted for now.

A quick google turns up this:
http://www.freebsd.org/cgi/query-pr.cgi?pr=83845


> use log2(x) = log(x)/log(2) if log2 is a problem

Is M_LN2 commonly defined, or is log(2) the safe way to go?

-- 
M?ns Rullg?rd
mru at inprovide.com