[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec avcodec.h, 1.435, 1.436 utils.c, 1.167, 1.168 mpegvideo.c, 1.499, 1.500

[Alexander Strasser]

Hi,

Michael Niedermayer wrote:
> On Mon, Dec 26, 2005 at 03:35:05AM +0100, Alexander Strasser wrote:
> > Michael Niedermayer CVS wrote:
> > > Update of /cvsroot/ffmpeg/ffmpeg/libavcodec
> > > In directory mail:/var2/tmp/cvs-serv16356
> > > 
> > > Modified Files:
> > > 	avcodec.h utils.c mpegvideo.c 
> > > Log Message:
> > > support downscaling frames for dynamic b frame decission
> > 
> >   Shouldn't a version number have been incremented with
> > this and maybe your other change with the new b_frame_strategy?
> > (And maybe some other changes i didn't notice.)
> 
> hmm, i thought about that too, IMHO no, or increase the last integer
> as these additions to AVCodecContext can be accessed through AVOption
> so this should be API&ABI compatible anyone accessing them directly 
> shouldnt expect compatibility 

  Ok, you are pushing AVOption usage. Fine with me.

> >   Maybe it would still be good to increment the version now.
> > 
> >   There is also a lack of documentation about it (there is
> > only a few mails in the archive of ffmpeg-devel). Maybe
> > the attached patch would be a beginning (could be better
> > i know).
> 
> patch ok, feel free to commit

  commited

  As I asked before, I am not clear about the second part
adding a new function to the API should be API compatible,
and ABI compatible too, so changing the second component is
meant to be ABI compatible?

  If so i should mention that explicitly for clarity.

  Also my previous argumentation was flawed because of
me not taking into account that AVOption solves the
problems with the many ABI incompatible changes.

  Also could it be that your answer to that part of my
mail vanished somehow? You normally write [...] if you
skip parts.

  Alex (beastd)