[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec avcodec.h, 1.435, 1.436 utils.c, 1.167, 1.168 mpegvideo.c, 1.499, 1.500

[Alexander Strasser]

Hi,

Michael Niedermayer CVS wrote:
> Update of /cvsroot/ffmpeg/ffmpeg/libavcodec
> In directory mail:/var2/tmp/cvs-serv16356
> 
> Modified Files:
> 	avcodec.h utils.c mpegvideo.c 
> Log Message:
> support downscaling frames for dynamic b frame decission

  Shouldn't a version number have been incremented with
this and maybe your other change with the new b_frame_strategy?
(And maybe some other changes i didn't notice.)

  Maybe it would still be good to increment the version now.

  There is also a lack of documentation about it (there is
only a few mails in the archive of ffmpeg-devel). Maybe
the attached patch would be a beginning (could be better
i know).
  Also does changing the second component imply binary
compatibility or not? I think probably not, because else
we would have to change the first component pretty often.
If so i should maybe add it in the explanation for the sake
of clarity.

  Alex (beastd)
-------------- next part --------------
Index: doc/ffmpeg-doc.texi
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/doc/ffmpeg-doc.texi,v
retrieving revision 1.100
diff -u -r1.100 ffmpeg-doc.texi
--- doc/ffmpeg-doc.texi	17 Dec 2005 18:14:26 -0000	1.100
+++ doc/ffmpeg-doc.texi	26 Dec 2005 02:24:46 -0000
@@ -1263,6 +1263,16 @@
     Never write to unallocated memory, never write over the end of arrays,
     always check values read from some untrusted source before using them
     as array index or other risky things.
+ at item
+    Remember to check if you need to bump versions for the specific libav
+    parts (libavutil,libavcodec,libavformat) you are changing. You need
+    to change the version integer and the version string.
+    Incrementing the first component means no backward compatibility to
+    previous version (e.g. removal of a function).
+    Incrementing the second component means backward compatible change
+    (e.g. addition of a function).
+    Incrementing the third component means a noteworthy binary compatible
+    change (e.g. encoder bug fix that matters for the decoder).
 @end enumerate
 
 We think our rules are not too hard. If you have comments, contact us.