[DVDnav-discuss] [libdvdnav-devel] [PATCH] Cleanup ifoFree()

[Jean-Baptiste Kempf]

On 05 Jan, Steve Dibb wrote :
> - Move all ifoFree_*() functions only called once directly into
>   ifoFree()
> - Proper checks for NULL pointers, freeing pointers
> ---
>  src/dvdread/ifo_read.h |  13 +-
>  src/ifo_read.c         | 503
>   ++++++++++++++++++++++++------------------------- 2 files changed,
>   244 insertions(+), 272 deletions(-)
> 
> diff --git a/src/dvdread/ifo_read.h b/src/dvdread/ifo_read.h
> index 97f4179..d29c3f9 100644
> --- a/src/dvdread/ifo_read.h
> +++ b/src/dvdread/ifo_read.h
> @@ -209,19 +209,8 @@ int ifoRead_TXTDT_MGI(ifo_handle_t *);
>   * below are safe:  they will not mind if you attempt to free part of
> an IFO
>   * file which was not read in or which does not exist.
>   */
> -void ifoFree_PTL_MAIT(ifo_handle_t *);
> -void ifoFree_VTS_ATRT(ifo_handle_t *);
> -void ifoFree_TT_SRPT(ifo_handle_t *);
> -void ifoFree_VTS_PTT_SRPT(ifo_handle_t *);
> -void ifoFree_FP_PGC(ifo_handle_t *);
> -void ifoFree_PGCIT(ifo_handle_t *);
> -void ifoFree_PGCI_UT(ifo_handle_t *);
>  void ifoFree_VTS_TMAPT(ifo_handle_t *);
> -void ifoFree_C_ADT(ifo_handle_t *);
> -void ifoFree_TITLE_C_ADT(ifo_handle_t *);
> -void ifoFree_VOBU_ADMAP(ifo_handle_t *);
> -void ifoFree_TITLE_VOBU_ADMAP(ifo_handle_t *);
> -void ifoFree_TXTDT_MGI(ifo_handle_t *);
> +void ifoFree_PGCI_UT(ifo_handle_t *);

This is a break of the API, of course. You cannot do this.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device