[DVDnav-discuss] Possible libdvdnav crash

[Jan Janssen]

Erik Hovland <erik at ...> writes:

> 
> Do you happen to have any extra output from the run? I put a couple of
> error messages in there to try to figure out why set_PGCN() is
> crapping out.
> 
> >> What do these two patches do? It may actually be the right thing to do
> >> in this instance, so I am curious what the error messaging patch says
> >> without using the return instead of assert patch.
> >
> >     assertion=assertion <at> entry=0x7ffff3087b9b "(signed)*pos != -1",
> > file=file <at> entry=0x7ffff3087b8b "src/searching.c", line=line <at>
entry=567,
> >     function=function <at> entry=0x7ffff3087e50 <__PRETTY_FUNCTION__.5455>
> > "dvdnav_get_position") at assert.c:92
> > #3  0x00007ffff7424552 in __GI___assert_fail
> > (assertion=assertion <at> entry=0x7ffff3087b9b "(signed)*pos != -1",
> > file=file <at> entry=0x7ffff3087b8b "src/searching.c",
> >     line=line <at> entry=567, function=function <at> entry=0x7ffff3087e50
> > <__PRETTY_FUNCTION__.5455> "dvdnav_get_position") at assert.c:101
> > #4  0x00007ffff307f7ee in dvdnav_get_position (this=0x7fffc4001110,
> >
> > If I comment out the assertion on line 567, vlc starts playing the actual
> > film, skipping the menu.
> 
> The assert on line 567 in searching.c looks a lot more like an assert
> should. How about the attached patch? What does it do? It removes the
> assert, but it also returns an error message if no position is found.
> 
> Thanks
> 
> E
> 

Vlc starts skips the menu and starts playing the film with all 3 patches
applied,
while mplayer manages to show me the menu even without the patches.

Here's the relevant excerpt of "vlc -vv dvd://":
libdvdnav: Using dvdnav version 5.0.0
libdvdnav: DVD Title: Verteufelte Zeit
libdvdnav: DVD Serial Number: 4437651C9BFF5FBF
libdvdnav: DVD Title (Alternative): VolumeSet 1390480857
libdvdnav: Unable to find map file '/home/medhefgo/.dvdnav/Verteufelte Zeit.map'
libdvdnav: DVD disk reports itself with Region mask 0x00000000. Regions: 1 2
3 4 5 6 7 8
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
[00007f0330000e78] dvdnav demux debug: trying to go to dvd menu
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
[00007f0330000e78] core demux debug: using access_demux module "dvdnav"
[00007f033005e8a8] core demux meta debug: looking for meta reader module
matching "any": 1 candidates
[00007f033005e8a8] core demux meta debug: no meta reader modules matched
[00007f03340009b8] core input debug: `dvd://' successfully opened
[00007f0330000e78] dvdnav demux debug: DVDNAV_HOP_CHANNEL
[00007f03340009b8] core input error: ES_OUT_RESET_PCR called
libdvdread: Attempting to retrieve all CSS keys
libdvdread: This can take a _long_ time, please be patient
libdvdread: Get key for /VIDEO_TS/VTS_01_0.VOB at 0x00000170
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_01_1.VOB at 0x000001a0
libdvdread: Elapsed time 0
libdvdread: Found 1 VTS's
libdvdread: Elapsed time 0
[00007f0330000e78] dvdnav demux debug: DVDNAV_VTS_CHANGE
[00007f0330000e78] dvdnav demux debug:      - vtsN=1
[00007f0330000e78] dvdnav demux debug:      - domain=8
[00007f03340009b8] core input error: ES_OUT_RESET_PCR called
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
[00007f0330000e78] dvdnav demux debug: DVDNAV_CELL_CHANGE
[00007f0330000e78] dvdnav demux debug:      - cellN=0
[00007f0330000e78] dvdnav demux debug:      - pgN=1
[00007f0330000e78] dvdnav demux debug:      - cell_length=5400000
[00007f0330000e78] dvdnav demux debug:      - pg_length=39600
[00007f0330000e78] dvdnav demux debug:      - pgc_length=39600
[00007f0330000e78] dvdnav demux debug:      - cell_start=0
[00007f0330000e78] dvdnav demux debug:      - pg_start=0
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
[00007f0330000e78] dvdnav demux debug: DVDNAV_SPU_CLUT_CHANGE
[00007f0330000e78] dvdnav demux debug: DVDNAV_SPU_STREAM_CHANGE
[00007f0330000e78] dvdnav demux debug:      - physical_wide=0
[00007f0330000e78] dvdnav demux debug:      - physical_letterbox=0
[00007f0330000e78] dvdnav demux debug:      - physical_pan_scan=0
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
[00007f0330000e78] dvdnav demux debug: buttonUpdate not done b=1 t=0
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
libdvdnav: Language 'en' not found, using '' instead
libdvdnav: Menu Languages available:  
[00007f03340009b8] core input debug: selecting program id=0
[00007f03300419f8] core decoder debug: looking for decoder module matching
"any": 43 candidates
[00007f03300419f8] core decoder debug: using decoder module "spudec"
[00007f03300419f8] spudec decoder debug: invalid starting packet (size < 4
or pts <=0)
[00007f03300419f8] spudec decoder debug: spu size: 0, i_pts: 0 i_buffer: 128
[00007f0330000e78] dvdnav demux debug: DVDNAV_AUDIO_STREAM_CHANGE
[00007f0330000e78] dvdnav demux debug:      - physical=0
libdvdread: Can't seek to block 805632480
[00007f0330000e78] dvdnav demux warning: cannot get next block (Error
reading NAV packet.)
[00007f0330000e78] dvdnav demux debug: jumping to first title
[00007f0330000e78] dvdnav demux debug: DVDNAV_HOP_CHANNEL
[00007f03340009b8] core input error: ES_OUT_RESET_PCR called
[00007f03300419f8] spudec decoder debug: invalid starting packet (size < 4
or pts <=0)
[00007f03300419f8] spudec decoder debug: spu size: 0, i_pts: 0 i_buffer: 128
[00007f0330000e78] dvdnav demux debug: DVDNAV_VTS_CHANGE
[00007f0330000e78] dvdnav demux debug:      - vtsN=1
[00007f0330000e78] dvdnav demux debug:      - domain=2
[00007f03340009b8] core input error: ES_OUT_RESET_PCR called
[00007f03300419f8] spudec decoder debug: invalid starting packet (size < 4
or pts <=0)
[00007f03300419f8] spudec decoder debug: spu size: 0, i_pts: 0 i_buffer: 128
[00007f03300419f8] core decoder debug: removing module "spudec"
[00007f03300419f8] core decoder debug: killing decoder fourcc `spu ', 0 PES
in FIFO
[00007f03340009b8] core input debug: Program doesn't contain anymore ES
[00007f0330000e78] dvdnav demux debug: DVDNAV_CELL_CHANGE
[00007f0330000e78] dvdnav demux debug:      - cellN=1
[00007f0330000e78] dvdnav demux debug:      - pgN=1
[00007f0330000e78] dvdnav demux debug:      - cell_length=606337200
[00007f0330000e78] dvdnav demux debug:      - pg_length=606337200
[00007f0330000e78] dvdnav demux debug:      - pgc_length=606337200
[00007f0330000e78] dvdnav demux debug:      - cell_start=0
[00007f0330000e78] dvdnav demux debug:      - pg_start=0
[00007f0330000e78] dvdnav demux debug: DVDNAV_SPU_CLUT_CHANGE
[00007f0330000e78] dvdnav demux debug: DVDNAV_SPU_STREAM_CHANGE
[00007f0330000e78] dvdnav demux debug:      - physical_wide=-1
[00007f0330000e78] dvdnav demux debug:      - physical_letterbox=-1
[00007f0330000e78] dvdnav demux debug:      - physical_pan_scan=-1
[00007f0330000e78] dvdnav demux debug: buttonUpdate not done b=1 t=1
[00007f0330000e78] dvdnav demux debug: DVDNAV_AUDIO_STREAM_CHANGE
[00007f0330000e78] dvdnav demux debug:      - physical=0