[DVDnav-discuss] Possible libdvdnav crash

[Erik Hovland]

Do you happen to have any extra output from the run? I put a couple of
error messages in there to try to figure out why set_PGCN() is
crapping out.

>> What do these two patches do? It may actually be the right thing to do
>> in this instance, so I am curious what the error messaging patch says
>> without using the return instead of assert patch.
>
>     assertion=assertion at entry=0x7ffff3087b9b "(signed)*pos != -1",
> file=file at entry=0x7ffff3087b8b "src/searching.c", line=line at entry=567,
>     function=function at entry=0x7ffff3087e50 <__PRETTY_FUNCTION__.5455>
> "dvdnav_get_position") at assert.c:92
> #3  0x00007ffff7424552 in __GI___assert_fail
> (assertion=assertion at entry=0x7ffff3087b9b "(signed)*pos != -1",
> file=file at entry=0x7ffff3087b8b "src/searching.c",
>     line=line at entry=567, function=function at entry=0x7ffff3087e50
> <__PRETTY_FUNCTION__.5455> "dvdnav_get_position") at assert.c:101
> #4  0x00007ffff307f7ee in dvdnav_get_position (this=0x7fffc4001110,
>
> If I comment out the assertion on line 567, vlc starts playing the actual
> film, skipping the menu.

The assert on line 567 in searching.c looks a lot more like an assert
should. How about the attached patch? What does it do? It removes the
assert, but it also returns an error message if no position is found.

Thanks

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: error-out-instead-of-assert-if-no-position.patch
Type: text/x-patch
Size: 805 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20140318/6a7d6db4/attachment.bin>