[DVDnav-discuss] [PATCH] Initialize dvd_reader_t struct in DVDOpenImageFile

[Dominik 'Rathann' Mierzejewski]

Hello Richard,

On Sunday, 26 January 2014 at 17:13, Richard Hulme wrote:
> Hi,
> 
> This is a patch I found in MythTV's copy of libdvdread that seems
> like it could/should be upstream too.  It ensures that the
> dvd_reader_t struct is initialized (e.g. the css_state field is
> currently undefined if 'have_css' is false).

Thanks for forwarding the patch.

If I understand correctly, with that memset in place, some of the
subsequent assignments
  dvd->path_root = NULL;
[...]
  dvd->udfcache = NULL;
[...]
  dvd->css_title = 0;

are not necessary anymore. Actually, that case of leaving css_state
uninitialized is a genuine bug, but I'm not sure if using memset
is the right solution. Does anyone else have thoughts on this case?

Regards,
Dominik

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"