[DVDnav-discuss] Return an error in dvdnav_get_position instead of asserting

Jean-Baptiste Kempf jb at videolan.org
Sun Aug 31 19:52:12 CEST 2014


On 31 Aug, Richard Hulme wrote :
> >-  assert((signed)*pos != -1);
> >+  if((signed)*pos == -1)
> >+    return DVDNAV_STATUS_ERR;
> >
> >    pthread_mutex_unlock(&this->vm_lock);
> 
> Shouldn't the two new lines come *after* the unlock?

Yep. Fixed and Applied.

Thanks for noticing, I thought I was a bit lonely on this project :)


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the DVDnav-discuss mailing list