[DVDnav-discuss] [PATCH] libdvdread: remove unused variables; cleanup return syntax

[Paul Menzel]

Dear Steve,


thank you for your patch.


Am Dienstag, den 15.04.2014, 11:44 -0600 schrieb Steve Dibb:
> diff --git a/src/dvd_udf.c b/src/dvd_udf.c
> index dc5f9af..678a984 100644
> --- a/src/dvd_udf.c
> +++ b/src/dvd_udf.c
> @@ -416,12 +416,12 @@ static int UDFPartition( uint8_t *data, uint16_t
> *Flags, uint16_t *Number,
>   */
>  static int UDFLogVolume( uint8_t *data, char *VolumeDescriptor )
>  {
> -  uint32_t lbsize, MT_L, N_PM;
> +  uint32_t lbsize;
>    Unicodedecode(&data[84], 128, VolumeDescriptor);
>    lbsize = GETN4(212);  /* should be 2048 */
> -  MT_L = GETN4(264);    /* should be 6 */
> -  N_PM = GETN4(268);    /* should be 1 */

Did the compiler complain about these?

> -  if (lbsize != DVD_VIDEO_LB_LEN) return 1;
> +  if (lbsize != DVD_VIDEO_LB_LEN)
> +    return 1;
> +

The syntax is the same, isn’t it? You changed the coding style?

>    return 0;
>  }

The diff looks good, but could you please send in patches formatted with
`git format-patch` and even split this up, so the commit summary stays
short?


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20140416/fa52ef3f/attachment.asc>