[DVDnav-discuss] VLC segfault playing DVD

[Paul Menzel]

Dear Cathy,


Am Mittwoch, den 04.09.2013, 12:36 +1000 schrieb dvdnav.cathy_mcdonald at spamgourmet.com:

> I've tracked down a bug which is causing VLC to crash when playing the 
> Jack Reacher DVD. Is this the right forum for submitting a patch?
> 
> I checked out the source from 
> svn://svn.mplayerhq.hu/dvdnav/trunk/libdvdnav but I've also seen a later 
> version of the file I want to change at 
> https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/precise/libdvdnav/precise-proposed/view/head:/src/searching.c 
> <https://bazaar.launchpad.net/%7Eubuntu-branches/ubuntu/precise/libdvdnav/precise-proposed/view/head:/src/searching.c> 
> so I'm confused about which is the latest version of the code and which 
> repository is the source of truth for a start.
> 
> I notice that the changes include a bunch of new sanity checks but not 
> the one which fixes my issue.
> 
> The bug I found produces a segfault in the 
> dvdnav_describe_title_chapters function in searching.c. It fails at the line
>    cellnr = pgc->program_map[ptt[i].pgn-1];
> because for some reason pgc->program_map is NULL. When I add a check for 
> this condition like
>      if(pgc->program_map == NULL) {
>        printerr("Program map missing.");
>        continue;
>      }
> the DVD will play.

nice find! Please send the patch here. I do not know, if DVDs are
allowed to do that, but they do not seem to care anyway.

Please send a patch for the Subversion repository with a commit message
detailing what you found above (program versions too) and the exact DVD
you have (region).


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20130904/c2d73362/attachment.asc>