[DVDnav-discuss] [PATCH] Add serialization support

[Richard Hulme]

On 21/10/13 14:51, Roger Pack wrote:
> On 10/18/13, Richard Hulme <peper03 at yahoo.com> wrote:
>> Hi,
>>
>> The attached patch adds serialization support to libdvdnav, which
>> effectively allows DVD bookmarks to be saved and restored.  The current
>> VM state is converted to/from an ASCII string.
>>
>> This is a patch I created for MythTV, where it is currently in use.
>>
>> As I wrote in the submit description for MythTV:
>>
>> "The state snapshot code is borrowed/adapted from or inspired by XBMC
>> and Ogle."
>
> FWIW there was also this patch:
> http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2012-May/001715.html
> I wonder if it's related somehow...also what's the status, can it be
> merged to svn?

Hi Roger,

No, it's not related (at least not directly).

My patch was designed to allow the current state of the virtual machine 
to be saved and restored to allow DVD bookmarks to be implemented.  The 
patch you reference duplicates the virtual machine and everything else 
around it.

There are several ways the functionality in my patch could be 
implemented.  Saving the binary data would be somewhat more efficient 
but I wanted to avoid making the dvdnav_s structure public.  I also 
wanted to avoid any issues with data alignment.

Returning the data in text form makes it easy to store for almost any 
system.  The data can also be parsed (if necessary) by a human without 
too much trouble.  I felt that a full-on XML implementation was 
overkill, so just went with a simple format that was fairly 
straightforward to parse.

Richard.