[DVDnav-discuss] [PATCH] Add serialization support

Richard Hulme peper03 at yahoo.com
Fri Oct 25 17:04:53 CEST 2013


On 21/10/13 00:30, Paul Menzel wrote:
>>> Furthermore, running
>>>
>>>           $ cppcheck --version # from Debian Sid/unstable
>>>           Cppcheck 1.61
>>>           $ cppcheck --enable=all src/vm/vm.c # Cppcheck 1.6
>>>
>>> does not show anything regarding your patch.
>>
>> Is that good or bad?
>
> That’s good.

That's what I thought :)

>> Ok, I've made some changes (added the missing vm_serialize.c to
>> Makefile,
>
> I think you need to add it to `src/vm/Makefile.am`. Though that did not
> get it included into my main `Makefile` after running `./configure`.

Hmm.  To be honest, I didn't look at Makefile.am.  I'm getting the 
source from 'svn://svn.mplayerhq.hu/dvdnav/trunk/libdvdnav'.  There is 
no 'configure' checked in there.  There's a 'configure2.sh' but that 
isn't generating any makefiles.

Anyway, I've added the missing file to Makefile.am for completeness.

Richard.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: serialize.diff
Type: text/x-patch
Size: 12930 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20131025/3e3fb1c7/attachment.bin>


More information about the DVDnav-discuss mailing list