[DVDnav-discuss] [PATCH] Add serialization support

Paul Menzel paulepanter at users.sourceforge.net
Fri Oct 18 23:20:43 CEST 2013

Dear Richard,

Am Freitag, den 18.10.2013, 21:05 +0200 schrieb Richard Hulme:

> The attached patch adds serialization support to libdvdnav, which 
> effectively allows DVD bookmarks to be saved and restored.  The current 
> VM state is converted to/from an ASCII string.
> This is a patch I created for MythTV, where it is currently in use.
> As I wrote in the submit description for MythTV:
> "The state snapshot code is borrowed/adapted from or inspired by XBMC 
> and Ogle."

thank you for your patch.

Applying your patch to a git repository, committing it and doing `git
show` (with `git config color.ui auto` (default since 1.8.4)), it shows
several whitespace errors in `src/libdvdnav/Makefile`.

Furthermore, running

        $ cppcheck --version # from Debian Sid/unstable
        Cppcheck 1.61
        $ cppcheck --enable=all src/vm/vm.c # Cppcheck 1.6

does not show anything regarding your patch.

Your usage of {}, if it is put on the same or on the next line, in
`src/dvdnav.c` seems inconsistent.

> +  /* set the state. this will also start the vm on that state */
> +  /* means the next read block should be comming from that new */
> +  /* state */



-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20131018/3bdabb13/attachment.asc>

More information about the DVDnav-discuss mailing list