[DVDnav-discuss] [PATCH] libdvdread/src/ifo_read.c: Use 0 instead of NULL in integer comparison

[Paul Menzel]

Date: Mon, 18 Nov 2013 16:58:17 +0100

Both GCC 4.8.2 and Clang 3.4 warn about a format mismatch in a
comparison.

	libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -mno-ms-bitfields -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -MT ifo_read.lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c  -fPIC -DPIC -o .libs/ifo_read.o
	[…]
	ifo_read.c: In function 'ifoRead_PTL_MAIT':
	ifo_read.c:1313:34: warning: comparison between pointer and integer [enabled by default]
	   if(ifofile->vmgi_mat->ptl_mait == NULL)

	libtool: compile:  clang -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -MT ifo_read.lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c  -fPIC -DPIC -o .libs/ifo_read.o
	[…]
	ifo_read.c:1313:34: warning: comparison between pointer and integer ('uint32_t' (aka 'unsigned int') and 'void *')
	  if(ifofile->vmgi_mat->ptl_mait == NULL)
	     ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~

Fix this by using the integer 0 instead of `NULL`.
---
 libdvdread/src/ifo_read.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libdvdread/src/ifo_read.c b/libdvdread/src/ifo_read.c
index 5640e0a..f679bca 100644
--- a/libdvdread/src/ifo_read.c
+++ b/libdvdread/src/ifo_read.c
@@ -1310,7 +1310,7 @@ int ifoRead_PTL_MAIT(ifo_handle_t *ifofile) {
   if(!ifofile->vmgi_mat)
     return 0;
 
-  if(ifofile->vmgi_mat->ptl_mait == NULL)
+  if(ifofile->vmgi_mat->ptl_mait == 0)
     return 1;
 
   if(!DVDFileSeek_(ifofile->file, ifofile->vmgi_mat->ptl_mait * DVD_BLOCK_LEN))
-- 
1.8.4.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20131118/81bed5ca/attachment.asc>