[DVDnav-discuss] [PATCH] "dvdnav_jump_to_sector" as an alternative to "dvdnav_time_search" (REV 5: combined args to structs)

[Joakim Plate]

Whatever happened to revision 6?

Somebody just opened a pull request to incorporate this in xbmc:
https://github.com/xbmc/xbmc/pull/2957


On Mon, Apr 23, 2012 at 9:29 PM, Joakim Plate <elupus at ecce.se> wrote:

> On Mon, Apr 23, 2012 at 6:13 AM, gnosygnu <gnosygnu at gmail.com> wrote:
> > I spent some time looking at this today, and I think the effort is
> > going to be quite significant (at least by my abilities).
> >
> > The dsi information seems to be read by dvdnav_decode_packet which is
> > deep in dvdnav_get_next_cache_block. I think I would need a separate
> > dvdnav_t struct to "peek" at the jumped packet. If I use the existing
> > dvdnav_get_next_cache_block (*this), I would be overwriting the
> > existing state. Creating a 2nd dvdnav_t doesn't seem better.
> >
>
> I think it should just setup a time value which get's handled on next
> call to dvdnav_get_next_cache_block(). Imho it doesn't need to setup
> state anywhere closer than the closest tmap before requested time,
> then on next read after NAV packet have been parsed, do the more exact
> block jump.
>
> But as i said, can be looked at later as long as API doesn't need to be
> changed.
>