[DVDnav-discuss] [PATCH] hop_channel not reset when vm_reset is called

Erik Hovland erik at hovland.org
Tue Jul 2 00:40:42 CEST 2013

On Mon, Jul 1, 2013 at 1:55 AM, Richard <peper03 at yahoo.com> wrote:
> Hi,
> Calling vm_reset (via dvdnav_reset) does not currently reset the hop_channel
> field.  This leads to "Error reading NAV packet." errors on some DVDs
> because dvdnav_get_next_cache_block tries to prepare a HOP_CHANNEL event and
> read from a file which hasn't yet been opened.
> The attached patch resets the hop_channel field to zero.

Maybe vm->hop_channel = 0;?

Anyone else uncomfortable w/ hop_channel existing in vm_t and
vm_position_t? On top of this there is a bunch of code that shows +=
HOP_SEEK and then hop_channel++. At first look these variables are
difficult to understand.

I do not see an issue w/ the proposed fix.



Erik Hovland
erik at hovland.org

More information about the DVDnav-discuss mailing list