[DVDnav-discuss] [PATCH] Fix packed structures with mingw gcc >= 4.7

[Mike Frysinger]

On Saturday 26 January 2013 14:23:28 John Stebbins wrote:
> On 01/26/2013 11:20 AM, Mike Frysinger wrote:
> > On Saturday 26 January 2013 13:56:17 John Stebbins wrote:
> >> +    if test "$GCC" = "yes" ; then
> >> +        gcc_version="`$CC -dumpversion`"
> >> +        gcc_version_major=$(echo $gcc_version | cut -d"." -f1)
> >> +        gcc_version_minor=$(echo $gcc_version | cut -d"." -f2)
> >> +        gcc_version_patch=$(echo $gcc_version | cut -d"." -f3)
> >> +        if test $gcc_version_major -ge 4 -a $gcc_version_minor -ge 7 ;
> >> +            CFLAGS="-mno-ms-bitfields $CFLAGS"
> >> +        fi
> >> +    fi
> > 
> > why not test if the flag is supported and then use it whenever it is ? 
> > that way you don't have to check the gcc version.
> 
> Because I suck at autoconf and didn't know how...

not too many people would admit to being good at autotools :)

easiest thing is probably to copy ax_check_compile_flag.m4 from the autoconf-
archive project into the m4/ subdir and then do:
	AX_CHECK_COMPILE_FLAG([-mno-ms-bitfields],
		[CFLAGS="-mno-ms-bitfields $CFLAGS"])
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20130126/2c1d604d/attachment.asc>