[DVDnav-discuss] [PATCH] Fix packed structures with mingw gcc >= 4.7

John Stebbins stebbins at jetheaddev.com
Sat Jan 26 20:23:28 CET 2013


On 01/26/2013 11:20 AM, Mike Frysinger wrote:
> On Saturday 26 January 2013 13:56:17 John Stebbins wrote:
>> +    if test "$GCC" = "yes" ; then
>> +        gcc_version="`$CC -dumpversion`"
>> +        gcc_version_major=$(echo $gcc_version | cut -d"." -f1)
>> +        gcc_version_minor=$(echo $gcc_version | cut -d"." -f2)
>> +        gcc_version_patch=$(echo $gcc_version | cut -d"." -f3)
>> +        if test $gcc_version_major -ge 4 -a $gcc_version_minor -ge 7 ;
>> +            CFLAGS="-mno-ms-bitfields $CFLAGS"
>> +        fi
>> +    fi
> why not test if the flag is supported and then use it whenever it is ?  that 
> way you don't have to check the gcc version.
> -mike

Because I suck at autoconf and didn't know how...

-- 
John      GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01  83F0 49F1 D7B2 60D4 D0F7


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20130126/d7223c01/attachment.asc>


More information about the DVDnav-discuss mailing list