[DVDnav-discuss] [PATCH][libdvdread] remove needless _LIBC checks from libdvdread

Erik Auerswald auerswal at unix-ag.uni-kl.de
Fri Feb 22 22:57:49 CET 2013


On 02/18/2013 05:55 AM, Mike Frysinger wrote:
> On Saturday 09 February 2013 16:18:50 Erik Auerswald wrote:
>> the first attached patch removes preprocessor checks for _LIBC, because
>> libdvdread is not GNU Libc and does never #define _LIBC.
> the files you're modifying are copied from elsewhere.

Copied once, there is nobody trying to keep them up to date. They should 
have been cleaned up back then, of course.

To clarify: it is _not_ the question if upstream changed anything in 
these files since they were copied. The issue is that taking a random 
code snapshot and keeping it that way without thought is the very 
definition of bitrot.

> hacking away at it gains literally nothing.

I disagree.

> what exactly is the point ?  for getopt.c, it's not like
> you really improved it -- the file is still full of portability hacks from all
> over.

Every simplification is an improvement.


More information about the DVDnav-discuss mailing list