[DVDnav-discuss] r1292 - in trunk/libdvdnav: configure.ac configure2

[Dominik 'Rathann' Mierzejewski]

On Thursday, 05 December 2013 at 06:27, Mike Frysinger wrote:
> On Wednesday 04 December 2013 18:51:38 rathann wrote:
> > Modified: trunk/libdvdnav/configure2
> > 
> >  SHARED=yes
> >  STATIC=yes
> > -DVDREAD_CONFIG=dvdread-config
> > +DVDREAD_CONFIG=""
> > +DVDREAD_PKG_CONFIG="pkg-config dvdread"
> >  PREFIX=/usr/local/
> >  INSTALLSTRIP=-s
> >  USEDEBUG=-g
> > @@ -104,8 +105,14 @@ test -z "$shlibdir" && shlibdir=$PREFIX/
> >  test -z "$incdir" && incdir=$PREFIX/include/dvdnav
> > 
> >  dvdread=no
> > +if test -z "$DVDREAD_CONFIG" ; then
> > +DVDREAD_CONFIG="pkg-config dvdread"
> > +$DVDREAD_CONFIG --exists >> /dev/null 2>&1 && dvdread=yes
> > +fi
> 
> i don't know what this configure2 is, but you shouldn't hard code `pkg-config` 
> anywhere.  the top of the script should do something like:
> : ${PKG_CONFIG:=pkg-config}
> 
> and the rest of the script would do:
> 	${PKG_CONFIG} ...
> instead of doing:
> 	pkg-config ...

Should be fixed in SVN.

Regards,
Dominik
-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"