[DVDnav-discuss] [PATCH v2] libdvdread/src/ifo_read.c: Abort when PTT search table has zero entries

[Dominik 'Rathann' Mierzejewski]

Hi, Paul.

On Monday, 18 November 2013 at 17:29, Paul Menzel wrote:
> Date: Mon, 18 Nov 2013 16:31:53 +0100
> 
> The static analyzer from LLVM/Clang 1:3.4~svn194079-1 reports a possible
> allocation of size 0 in `libdvdread/src/ifo_read.c`.
> 
>         $ scan-build -o scan-build make
>         $ scan-view scan-build/2013-11-18-155601-16168-1
> 
> When `vts_ptt_srpt->nr_of_srpts` is zero the allocation size is zero.
> 
>         vts_ptt_srpt->title = malloc(vts_ptt_srpt->nr_of_srpts * sizeof(ttu_t));
> 
> The manual of the function `malloc` writes the following.
> 
>         If size is 0, then malloc() returns either NULL, or a unique
>         pointer value that can later be successfully passed to free().
> 
> So check for 0 and, if it is, abort by going to the label `fail`.

Applied, thanks.

Regards,
Dominik
-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"