[DVDnav-discuss] [PATCH] ifo_read.c: DVDs created by LG RC590M violate `n % 4 == 0`

[Paul Menzel]

Date: Sun, 28 Apr 2013 12:25:38 +0200

DVDs created with the VDR-to-DVD device LG RC590M display some warnings.

    $ dvdbackup -M -i /dev/sr0 -o /tmp
    libdvdread: Encrypted DVD support unavailable.
    ************************************************
    **                                            **
    **  No css library available. See             **
    **  /usr/share/doc/libdvdread4/README.css     **
    **  for more information.                     **
    **                                            **
    ************************************************
    *** Zero check failed in ifo_read.c:570
        for vmgi_mat->zero_3 = 0x00000000010000000000000000000000000000
    *** Zero check failed in ifo_read.c:570
        for vmgi_mat->zero_3 = 0x00000000010000000000000000000000000000

    *** libdvdread: CHECK_VALUE failed in ifo_read.c:1232 ***
    *** for n % 4 == 0 ***


    *** libdvdread: CHECK_VALUE failed in ifo_read.c:1232 ***
    *** for n % 4 == 0 ***


    *** libdvdread: CHECK_VALUE failed in ifo_read.c:1232 ***
    *** for n % 4 == 0 ***

Add a comment about the second warning to the source code.
---
To see how widespread that error is, maybe the value of `i` and `n`
should be printed and the user be asked to report that to the dvdnav
list?

 libdvdread/src/ifo_read.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/libdvdread/src/ifo_read.c b/libdvdread/src/ifo_read.c
index c8f3194..5c89831 100644
--- a/libdvdread/src/ifo_read.c
+++ b/libdvdread/src/ifo_read.c
@@ -1211,6 +1211,7 @@ int ifoRead_VTS_PTT_SRPT(ifo_handle_t *ifofile) {
        Titles with 0 PTTs. */
     if(n < 0) n = 0;
 
+    /* DVDs created by the VDR-to-DVD device LG RC590M violate the following requirement */
     CHECK_VALUE(n % 4 == 0);
 
     vts_ptt_srpt->title[i].nr_of_ptts = n / 4;
-- 
1.7.10.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20130428/a734b885/attachment.asc>