[DVDnav-discuss] [PATCH] handle duplicate language units and pgc's more gracefully

Erik Hovland erik at hovland.org
Tue Oct 16 20:26:47 CEST 2012


I like this patch. I can see the utility of this change. The one thing
that makes me nervous is that the reference counting is done by
modifying the public structs and storing the reference count there.

I am likely to accept this patch just b/c it has been going for
so long, but I would like to think about the solution a bit before
giving up on a solution that puts the ref counting outside of the
structs.

Any thoughts are appreciated.

E

On Sat, Oct 13, 2012 at 6:00 AM, John Stebbins <stebbins at jetheaddev.com> wrote:
> This patch never got accepted (probably because it's touches a lot and
> made you nervous), but HandBrake has been applying this for 3 years now.
>
> Some discs have large numbers of repeated language units and pgc's that
> cause extreme memory consumption and file i/o issues. scanning all the
> titles on such discs is unusably slow. detect such repeats and ref-count
> the data structures to avoid reading and storing duplicate info.
>
>
> _______________________________________________
> DVDnav-discuss mailing list
> DVDnav-discuss at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss



-- 
Erik Hovland
erik at hovland.org
http://hovland.org/


More information about the DVDnav-discuss mailing list