[DVDnav-discuss] [PATCH] detect if path is physical dvd

[Erik Hovland]

> We are evaluating using your github versions of dvdread and dvdnav in
> handbrake.  So I've been having a close look at what patches you've
> accepted and what's still missing.  I've got a few patches I'm going to
> through at you.

Although I have no problem w/ HandBrake using that repo, it
means that I have grown too lax on pushing those changes into the
mplayer svn. It is still the canonical place for these libraries. I am
keen to get another release through mplayerhq out soon. After I review
and apply these patches, I intend to get the new jump function
into the libraries and then get a release out. That way HandBrake, et al
can continue to use mplayerhq.

> The first was part of another patch that I submitted.  You merged the
> rest but left this part out.
>
> It's purpose is to detect if an input path is a physical drive (on
> windows), and if so attempt to open it as an image.  The current code
> will only attempt to open the path as an image if the path contains no
> directory components (e.g. "X:" or "X:\").  So if the path instead is
> "X:\VIDEO_TS", it will fail to open it as an image and instead open it
> as a directory tree and css decryption will not work. This makes the
> behavior more similar to what happens on other platforms.

I like how you preserved OS2. I am sure that will be appreciated.

Applied to my tree.

Thanks

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/