[DVDnav-discuss] [PATCH] do not close file twice

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Nov 6 21:27:09 CET 2012


On Tue, Nov 06, 2012 at 11:56:43AM -0800, Erik Hovland wrote:
> On Tue, Nov 6, 2012 at 11:28 AM, Reimar Döffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > On Tue, Nov 06, 2012 at 11:22:26AM -0800, Erik Hovland wrote:
> >> On Tue, Nov 6, 2012 at 11:11 AM, Reimar Döffinger
> >> <Reimar.Doeffinger at gmx.de> wrote:
> >> > On Tue, Nov 06, 2012 at 10:43:14AM -0800, Erik Hovland wrote:
> >> >> Also dealt w/ in the commit in November '11 in my github tree:
> >> >> https://github.com/microe/libdvdnav
> >> >
> >> > What's the point in hoarding such trivial patches for almost a
> >> > year in a repository nobody knows about (it sure isn't on the homepage)?
> >> > I see that larger patches might needs some testing or longer work on
> >> > them, but that is hardly what I'd consider a good use of
> >> > private/development repositories.
> >>
> >> There is no point in hoarding. The only reason most of these
> >> patches have not been committed is b/c of general laziness on
> >> my part.
> >>
> >> I still consider mplayerhq svn to be the canonical place for all libdvdread
> >> and libdvdnav development. So I *pinky-swear* promise to get my tree
> >> pushed into that repository as fast as I can.
> >>
> >> Is it too difficult to try my tree in the meantime?
> >
> > Fairly, the thing I am "trying" is fixing MPlayer's Coverity scan results,
> > integrating your tree is a bit annoying though if you're really
> > interested I can give it a try.
> 
> Ah, this makes sense. There are a lot of commits to my repo that
> address several coverity defects.
> 
> Is there a way to get access to the MPlayer scan results?

Yes, ask me for access. (+ tell me which email address I should give to
them).
Obviously you could of course try applying for your own project account
for libdvd*, see e.g. http://scan.coverity.com/developers-faq.html
However to upload a scan you need to have a way to get all code that
you want analyzed compiled in one go.


More information about the DVDnav-discuss mailing list