[DVDnav-discuss] [PATCH] Fix failed assertion when there's no menu (was Re: libdvdnav 4.1.4)

[Dominik 'Rathann' Mierzejewski]

On Monday, 10 October 2011 at 23:54, Erik Hovland wrote:
> >> libdvdread: Found 1 VTS's
> >> libdvdread: Elapsed time 0
> >> libdvdnav: Language 'en' not found, using '' instead
> >> libdvdnav: Menu Languages available:
> >> libdvdnav: Language 'en' not found, using '' instead
> >> libdvdnav: Menu Languages available:
> >> libdvdnav: Language 'en' not found, using '' instead
> >> libdvdnav: Menu Languages available:
> >> libdvdnav: *** pgci_ut handle is NULL ***
> >> totem: /builddir/build/BUILD/libdvdnav-4.1.4/src/vm/vm.c:1772: get_ID:
> >> Assertion `pgcit != ((void *)0)' failed.
> >
> > What is the title of this DVD? Could you provide an ISO image
> > for testing (privately, of course)?
> >
> > Does this still happen with current SVN sources?
> >
> > If yes, could you test the attached patch?
> 
> I am pretty sure that the return value has to be 0 and not -1.
> Sadly, libdvdnav (and vm.c especially) breaks the Unix convention of
> 0 being successful execution. Patch attached.

Applied.

> It is almost guaranteed that removing this assert is only the tip
> of the iceberg, there are many places in the code that are written like:
> if (!set_PGCN(target, pgcN))
>   assert(0);
> 
> But I am all for the removal of asserts in a library.

Patches? ;)

Regards,
Dominik

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"