[DVDnav-discuss] [PATCH] Fix out of array pointer access

[Erik Hovland]

On Fri, Dec 16, 2011 at 12:13 AM, Bryce Harrington <bryce at canonical.com> wrote:
> This patch fixes a segmentation fault hit when reading the DVD 'The
> Express'.  It prevents a read/write beyond end of an array due to using
> a length value taken from the DVD, which can exceed the allocated size.
>
> https://bugs.launchpad.net/ubuntu/+source/libdvdread/+bug/894170
>
> The patch was originally written by rickyrockrat (sorry, I don't have
> his email address) for 4.1.3.  I got the DVD and reproduced the segfault
> using 4.2.0 and verified the patch stops the segfault from happening.
> We're not confident this is the best fix though, so are posting it here
> for review.
>
> Signed-off-by:  Bryce Harrington <bryce at canonical.com>

Looks fine to me. I have added it to my tree.

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/