[DVDnav-discuss] libdvdread uses internal dlfcn on W32, unconditionally

[Erik Hovland]

> On W32 libdvdread unconditionally uses msvc/contrib/dlfcn.c
> While this allows libdvdread to be compiled out of the box, it
> prevents it from linking to any other dlfcn implementation. Namely -
> to dlfcn-win32 [1] (which is somewhat more POSIX-compliant).
>
> The attached patch is very simplistic (i.e. it unconditionally
> requires a working libdl somewhere), but it works for me. For trunk i
> would suggest re-writing it like this:
> check for dlopen in -lc
>  if that fails, check for dlopen in -ld
>    if that fails AND host is mingw, modify CFLAGS to use internal dlfcn
>
> Note that LDFLAGS modification should go AFTER (!) all AC_CHECK_LIB
> calls, because -no-undefined is no longer valid as a compiler option.
>
> [1] http://code.google.com/p/dlfcn-win32/

I have put this patch into my tree. It would be helpful if someone who
develops or builds on Windows tried out this patch, but it is highly likely
that I will push this patch as is into svn.

Thanks for the patch!

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/