[DVDnav-discuss] [PATCH] Fix failed assertion when there's no menu (was Re: libdvdnav 4.1.4)

[Dominik 'Rathann' Mierzejewski]

Hi Jean-Jacques,

On Monday, 03 January 2011 at 15:31, Jean-Jacques Sarton wrote:
> On Fedora 14 totem and vlc end both with folowing message:
> 
> libdvdread: Found 1 VTS's
> libdvdread: Elapsed time 0
> libdvdnav: Language 'en' not found, using '' instead
> libdvdnav: Menu Languages available:
> libdvdnav: Language 'en' not found, using '' instead
> libdvdnav: Menu Languages available:
> libdvdnav: Language 'en' not found, using '' instead
> libdvdnav: Menu Languages available:
> libdvdnav: *** pgci_ut handle is NULL ***
> totem: /builddir/build/BUILD/libdvdnav-4.1.4/src/vm/vm.c:1772: get_ID:
> Assertion `pgcit != ((void *)0)' failed.

What is the title of this DVD? Could you provide an ISO image
for testing (privately, of course)?

Does this still happen with current SVN sources?

If yes, could you test the attached patch?

Regards,
Dominik

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
-------------- next part --------------
Index: libdvdnav/src/vm/vm.c
===================================================================
--- libdvdnav/src/vm/vm.c	(revision 1233)
+++ libdvdnav/src/vm/vm.c	(working copy)
@@ -1762,7 +1762,8 @@
   pgcit_t *pgcit;
 
   pgcit = get_PGCIT(vm);
-  assert(pgcit != NULL);  /* ?? Make this return -1 instead */
+  if(!pgcit)
+    return -1;
 
   if(pgcN < 1 || pgcN > pgcit->nr_of_pgci_srp) {
 #ifdef TRACE