[DVDnav-discuss] [PATCH] Guarantee forward seek attempt moves position forward
stebbins at jetheaddev.com
Thu Oct 6 23:06:59 CEST 2011
On 10/06/2011 12:08 PM, Erik Hovland wrote:
>>>>>>> Ugh! That patch "worked" but was wrong. It was comparing an offset into
>>>>>>> title to raw sector numbers. Here's a correction.
>>>>>> Just a follow up to let you know that this patch is in my tree
>>>>>> currently. If you make any modifications, please feel free to
>>>>>> update this thread w/ a new patch.
>>>>> Thanks. I've done quite a bit of testing with this version and a "bad"
>>>>> disc I created with a dry-erase marker. It's performing solidly. Also
>>>>> got it into the hands of one of our users that had a few problem discs
>>>>> and it worked well for him.
>>>> Ping Nico. Could you approve/reject this?
>> Ping3. Anyone?
> It is still in my tree. If John could address Reimar's last qualms:
> | Is a whole lot simpler but still feels suboptimal.
> | I also don't know if handling the cell change is quite right here or
> | if it wouldn't belong into dvdnav_scan_admap...
> But I think that we could probably submit the patch w/out addressing
> these last issues.
I thought I had. I incorporated his suggestions and responded to the issue about admap.
From my previous emal on this patch:
"dvdnav_scan_admap didn't look like the right place for handling the cell
boundary because it currently doesn't touch the cell information at
all. In order to handle the boundary, it would have to replicate a lot
of code that is already in dvdnav_sector_search."
I didn't get further feedback.
John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 490 bytes
Desc: OpenPGP digital signature
More information about the DVDnav-discuss