[DVDnav-discuss] dvdnav patches from handbrake project
stebbins at jetheaddev.com
Thu Oct 6 17:00:56 CEST 2011
On 10/06/2011 06:58 AM, Jean-Baptiste Kempf wrote:
> On Thu, Oct 06, 2011 at 03:47:16PM +0200, Dominik 'Rathann' Mierzejewski wrote :
>>> * read-raw-device.patch
>>> On windows, use correct path when attempting to open the raw dvd device.
>>> Also check that it is a dvd device in order to avoid error message spam.
>> As above. Someone please test on Win32 and review.
> GetDriveTypeA <= Why?
> Why hardcoding 2 in path_copy = '\0'; ? What about /D: drive
'/D:'? I've never seen that. What's the '/' there for? If that's valid, then I guess we need to strchr for the ':'.
John GnuPG fingerprint: CADFA1DB594CA50EB79427284617578AADE759A1
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 490 bytes
Desc: OpenPGP digital signature
More information about the DVDnav-discuss