[DVDnav-discuss] [PATCH] "dvdnav_jump_to_sector" as an alternative to "dvdnav_time_search" (REV 1: handle delay when reading directly off disc)

gnosygnu gnosygnu at gmail.com
Sat Nov 19 03:53:17 CET 2011


> What about using the already existing ifo handle to re-read the tmap?
> int ifoRead_VTS_TMAPT(ifo_handle_t *);

Thanks. I should have found that myself. I've changed the code
accordingly for revision 4.

> I am still concerned that the vts_tmapt is not already set up.

I think the issue is in vm.c. From what I can tell, ifoOpenNewVTSI and
vm_reset are not calling "ifoRead_VTS_TMAPT". In contrast, both procs
call "ifoRead_VOBU_ADMAP".

If you want, I can submit a separate patch for this. I think there
would not be any adverse consequences of such a patch, aside from the
miniscule performance hit in loading the tmap. Admittedly though, my
familiarity with the vm.c is very little.

Also, on a separate note, I'd like to hold off on combining the
parameters into a struct. The changes are straightforward, but they
involve a lot of lines, and I'd like not to have such a big moving
target (i.e: keep submitting revisions that change lines upon lines).
Let me know if you feel strongly about combining the parameters, and I
will reprioritize.

Thanks.


More information about the DVDnav-discuss mailing list