[DVDnav-discuss] r1219 - trunk/libdvdnav/src/vm/vm.c

[Dominik 'Rathann' Mierzejewski]

On Monday, 22 November 2010 at 17:17, Erik Hovland wrote:
> >> @@ -1437,8 +1441,9 @@ static int process_command(vm_t *vm, lin
> >>        if(link_values.data2 != 0)
> >>       (vm->state).HL_BTNN_REG = link_values.data2 << 10;
> >>        if(!set_VTS_PTT(vm, (vm->state).vtsN, (vm->state).VTS_TTN_REG, link_values.data1))
> >> -     assert(0);
> >> -      link_values = play_PG(vm);
> >> +        link_values.command = Exit;
> >> +      else
> >> +        link_values = play_PG(vm);
> >>        break;
> >>      case LinkPGN:
> >>        /* Link to Program Number:data1 */
[...]

> > The three hunks above contain purely cosmetic (indentation) changes.
> > Please avoid mixing them with functional changes next time (i.e.
> > commit them separately, after functional).
> 
> Do they not turn assert(0) into VM exit commands?

They do, but they also change the indentation of these lines:

-      link_values = play_PG(vm);
...
+        link_values = play_PG(vm);

> I will endeavor to separate
> cosmetic changes from code changes.

Thanks! I will start a thread discussing a release soon.

Regards,
Dominik.

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"