[DVDnav-discuss] [PATCH] replace the magic constants in the parental management information

[Frédéric Marchal]

On Monday 22 November 2010 21:56:57 Erik Hovland wrote:
> > This patch replaces the hard coded number of levels in the parental
> > management information by a constant.
> > 
> > The size of the bit mask was also hard coded to 2 bytes. This patch
> > replaces it by sizeof(uint16_t) as it is defined as such in
> > dvdread/ifo_types.h.
> 
> I may just accept this. But is it possible to use nr_of_vtss or
> whatever the flag is in sizeof
> instead of uint16_t. It is highly unlikely (near impossible) that the
> sizes of entries in
> the DVD format are ever going to change. But it always makes more
> sense to do the
> sizeof on the variable instead of the type.

Do you mean something like the attached patch ?

Frederic
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libdvdread_replace_ptl_mait_magic_constants1.patch
Type: text/x-patch
Size: 1322 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20101122/4b63d3f7/attachment.bin>