[DVDnav-discuss] dvdnav patches from handbrake project

[Nico Sabbi]

John Stebbins ha scritto:
> On 05/28/2010 06:41 AM, Nico Sabbi wrote:
>    
> It's not clear to me which A03 you mean. The one in dvdnav or the one in
> dvdread.
>    

all in dvdread/

>
> Kempf wanted a rational for this.  He suggests we should only change
> what's used and accepts off_t and lseek changes.  My rational was that
> these defines cover all current and future large file issues.  For
> example, stat is currently used in dvd_reader.c.  Although stat doesn't
> currently require any of the 64bit extensions, defining off_t to off64_t
> changes the definition of struct stat.  This is going to cause
> mis-alignment of the member variables since it is filled in by the libc
> with the assumption that off_t is 32 bits and dvdread thinks it's 64
> bits.  Redefining stat makes sure we don't have this alignment problem.
>
>    
>> P06: please, explain
>> http://trac.handbrake.fr/browser/trunk/contrib/libdvdread/P06-darwin.patch
>>
>> the change in dvd_reader.c fits with the comment that in the original
>> code is wrong, but which one is correct?
>>      
> The comment above the test says one thing and the test does another.
> The comment is correct.  The patch fixes the test to do what the comment
> says.  Remember strncmp returns 0 when equal.
>    

it's what I meant