[DVDnav-discuss] [PATCH] crash while processing mac the ripper "feature title extract" images

Dominik 'Rathann' Mierzejewski dominik at greysector.net
Fri Mar 5 22:19:56 CET 2010


On Tuesday, 08 December 2009 at 17:15, John Stebbins wrote:
> On 12/07/2009 05:37 AM, Dominik 'Rathann' Mierzejewski wrote:
> >On Wednesday, 18 November 2009 at 00:41, John Stebbins wrote:
> >   
> >>Mac the ripper's feature title extraction removes menus from the
> >>resulting image, but does not remove navigation instructions that
> >>attempt to jump to those menus.  This patch checks that a menu exists
> >>before acting on such instructions.  If the menu does not exist, the it
> >>puts the vm into the stopped state.

[...]

> I didn't add a goto because I was trying to adhere to the style used in the
> rest of that function.  There are several places in that function where
> link_values.command is assigned Exit in error conditions and then "break"s.
> After having a second look, the other goto I added isn't necessary either.
> "return 0" is all that's needed there.
> 
> Anyway, I found another condition similar to the missing menu issue.  A jump
> to a missing VTS also crashes.  So here's an updated patch that addresses
> this as well.

Ping Nico. :)

Regards,
your friendly patch tracker. :)

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"


More information about the DVDnav-discuss mailing list