[DVDnav-discuss] dvdnav patches from handbrake project

Erik Hovland erik at hovland.org
Mon Jul 19 20:00:19 CEST 2010


>>>> * nav-missing-menu-abort.patch
>>>> This patch prevents an abort when a nav command tries to send you to a
>>>> menu that doesn't exist.
>>>> Mac the ripper's feature title extraction removes menus from the
>>>> resulting image, but does not remove navigation instructions that
>>>> attempt to jump to those  menus.  This patch checks that a menu exists
>>>> before acting on such instructions.  If the menu does not exist, the it
>>>> puts the vm into the stopped state.
>>>>
>>>
>>> This has a high likelihood of being committed by me. I just have to get
>>> my
>>> head around the error path handling.
>>>
>>
>> John,
>>
>> Is it possible to consolidate the valid pointer checks in vm_jump_menu?
>> See
>> the attached patch. I am probably going to break the original patch up
>> into at least
>> two different commits. Even though they treat the same problem they work
>> in
>> different functions.
>
> I can look at it. But it's going to have to wait a couple weeks. I'm very
> busy at a customers site for a while.

You have waited a long time and have been very patient. I'm sure I can
do the same.

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/


More information about the DVDnav-discuss mailing list