[DVDnav-discuss] dvdnav patches from handbrake project

Erik Hovland erik at hovland.org
Sun Jul 18 20:40:43 CEST 2010


>> * nav-missing-menu-abort.patch
>> This patch prevents an abort when a nav command tries to send you to a
>> menu that doesn't exist.
>> Mac the ripper's feature title extraction removes menus from the
>> resulting image, but does not remove navigation instructions that
>> attempt to jump to those  menus.  This patch checks that a menu exists
>> before acting on such instructions.  If the menu does not exist, the it
>> puts the vm into the stopped state.
>
> This has a high likelihood of being committed by me. I just have to get my
> head around the error path handling.

John,

Is it possible to consolidate the valid pointer checks in vm_jump_menu? See
the attached patch. I am probably going to break the original patch up
into at least
two different commits. Even though they treat the same problem they work in
different functions.

Thanks

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: return-to-prevent-crash-in-vm_jump_menu.patch
Type: text/x-patch
Size: 495 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20100718/8ca48920/attachment.bin>


More information about the DVDnav-discuss mailing list