[DVDnav-discuss] [PATCH] do not rely on _WIN32 #define

Jean-Baptiste Kempf jb at videolan.org
Tue Dec 28 11:46:40 CET 2010


Hello,

On Tue, Dec 28, 2010 at 11:19:38AM +0100, Diego Biurrun wrote :
> Newer versions of Cygwin no longer set the _WIN32 #define.  This is
> causing some problems that we worked around locally in MPlayer.
> I have replaced it with WIN32, which is used in other places in
> libdvdread, but possibly using __MINGW32__ and __CYGWIN__ is even
> better and makes the intent clearer.
> 
> I'd appreciate if somebody could test this since I have no Windows
> system.  I think libdvdread is supposed to build on Visual Studio
> as well, so testing that would be a bonus.

This will work on Win32.

However, the correct C99 define for win32 defined by the compiler is
_WIN32, not WIN32.

I have no idea why Cygwin is doing it that way... What version of gcc is
this?

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734


More information about the DVDnav-discuss mailing list