[DVDnav-discuss] [PATCH] Patch 2/5: EXTFINFO and Filetype 250

[Jorgen Lundman]

>> +void UDFFreeFile(dvd_reader_t *device, udf_file_t *File)
>> +{
>> +  free(File);
>> +}
>
> I think the wrapping of free is unnecessary here, especially when
> the device parameter is unused. dvd_reader.c changes would need
> to be adjusted accordingly as well.
>

Initially the allocation of the AD chain array was dynamic, and also needed to 
be free()d when the file was free()d. I made it static for simplicity, but 
decided to keep the free call so that, should it be made back into dynamic, all 
memory will still be released properly assuming everyone calls the UDFFreeFile() 
call.

Otherwise, I have no preference.

Lund

-- 
Jorgen Lundman       | <lundman at lundman.net>
Unix Administrator   | +81 (0)3 -5456-2687 ext 1017 (work)
Shibuya-ku, Tokyo    | +81 (0)90-5578-8500          (cell)
Japan                | +81 (0)3 -3375-1767          (home)