[DVDnav-discuss] [PATCH] Use 64bits file IO API and set to binary mode on OS/2

[Erik Hovland]

>>> This patch makes to use 64bits file IO API and to set a file handle to a
>>> binary mode explicitly on OS/2.
>>>
>>
>> Please separate functional and cosmetical changes in two patches. (You may
>> send
>> the cosmetic change after the first patch was approved.)
>>
>>
>
> The cosmetic change is caused by a functional change, that is, DosOpenL
> instead of DosOpen.  Nevertheless, should I separate the patch in two parts
> ?

I personally don't think this one requires two patches. There is no
trailing whitespace and the style of the patch mixes w/ the style
of the rest of the function. Sadly the function doesn't match the
style of the rest of the file. But don't submit a patch for that.

Barring any dissent from the cognizanti this patch will be committed
to libdvdnav in about 48 hours.

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/