[DVDnav-discuss] [PATCH 3/6] The version should be bumped to at least 5. But I am going to go to 6 on this one.

Erik Hovland erik at hovland.org
Sun Feb 15 19:56:06 CET 2009


>> Up the version compiled in to 906.
>>
>> Signed-off-by: Erik Hovland <erik at hovland.org>
>>
>> ---
>>
>>  src/dvdread/dvd_reader.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/dvdread/dvd_reader.h b/src/dvdread/dvd_reader.h
>> index 93c5d2f..be94cc7 100644
>> --- a/src/dvdread/dvd_reader.h
>> +++ b/src/dvdread/dvd_reader.h
>> @@ -43,7 +43,7 @@
>>  /**
>>   * The current version.
>>   */
>> -#define DVDREAD_VERSION 904
>> +#define DVDREAD_VERSION 906
>>
>>  /**
>>   * The length of one Logical Block of a DVD.
>>
>
> Can you explain this patch? Is it supposed to expose a supposed
> compatibility with dvdread-0.9.6? If so it's not ok: I never applied
> the buffer-alignment  stuff and I'm not going to apply it unless someone
> explains me why it's a good feature to have.

The only reason to have the patch in the set is for consistency's sake.
In fact, I am all for removing this define macro altogether as it exists
as a historical artifact to the original libdvdread.

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/



More information about the DVDnav-discuss mailing list