[DVDnav-discuss] [PATCH] Make dvd_stat_t public

Dominik 'Rathann' Mierzejewski dominik at greysector.net
Mon Dec 7 03:07:25 CET 2009


Hi!

On Sunday, 06 December 2009 at 22:44, Erik Hovland wrote:
> > This is accurate. Sorry for the flub. Is there a patch? I don't see
> > one on the bug or in this email thread. How does anyone else feel
> > about having dvd_stat be the only non-opaque struct? We could keep the
> > struct opaque and have allocation/deallocation functions. But that
> > would make the API incompatible w/ the previous library.
> 
> Would this patch be acceptable? I am assuming this is what was
> meant by making dvd_stat_t public. This patch does indeed make
> the example test compile.

Um, that's exactly like the patch I forgot to attach. :)
I checked the sources of libdvdread-0.9.7 and the struct is public
in dvd_reader.h, so if we want to be compatible, we have no choice
but to do the same, right? I think you should just commit it.

Regards,
R.

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"


More information about the DVDnav-discuss mailing list