[DVDnav-discuss] [patch] a few bugs found in dvdread and dvdnav

[John Stebbins]

Patches attached.

1. UDVGetVolumeIdentifier fails.
UDFGetVolumeIdentifier calls UDFGetPVD calls UDFGetDescriptor which fails
because bufsize is to small (8 bytes).  The error is in the call.
  if(!UDFGetDescriptor( device, 1, pvd_buf, sizeof(pvd_buf)))
sizeof(pvd_buf) gives the size of the pointer and not what it points at.  It
should be:
  if(!UDFGetDescriptor( device, 1, pvd_buf, DVD_VIDEO_LB_LEN))


2. libdvdread builds incorrectly on os x (darwin)
dvd_reader.c uses the define __DARWIN__ to enable darwin specific code, but it
is never defined anywhere.

3. Conversion of disk names to raw disk names incorrect.
On darwin and other bsd based systems, dvd_reader.c converts regular device
names to raw device names. e.g. "/dev/disk4" -> "/dev/rdisk4"
The test that determines if the conversion needs to be done is broken. 
It is fixed in libdvdread version 0.9.7.

4. libdvdread on mingw fails reading at 2G boundary.  largefile support.

5. dvdnav_reset deadlock on vm_lock.
dvdnav_reset takes the lock, then latter calls dvdnav_clear which tries to take
the lock again.  dead.  the unlock that is immediately after dvdnav_clear
should be moved to before it.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: darwin1.patch
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20090424/80c04e1c/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: darwin2.patch
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20090424/80c04e1c/attachment.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mingw-large-file.patch
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20090424/80c04e1c/attachment-0001.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: volume-name.patch
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20090424/80c04e1c/attachment-0001.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dvdnav-deadlock.patch
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20090424/80c04e1c/attachment-0002.txt>