[DVDnav-discuss] misc issues

[Diego Biurrun]

On Mon, Sep 15, 2008 at 08:56:13AM -0700, Dan Nicholson wrote:
> On Mon, Sep 15, 2008 at 8:42 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Mon, Sep 15, 2008 at 08:29:38AM -0700, Dan Nicholson wrote:
> >> On Sun, Sep 14, 2008 at 1:06 PM, Nico Sabbi <nicola.sabbi at poste.it> wrote:
> >> > Il giorno dom, 14/09/2008 alle 21.50 +0200, Diego Biurrun ha scritto:
> >> >> libdvdread and libdvdnav are full of
> >> >>
> >> >> - extern "C"
> >> >
> >> > uhm, there are quite a few MSVC fanboys here, maybe better keep them
> >>
> >> I guess you would first need to determine if you can use the API from
> >> a C++ program without the extern "C" declaration before removing them.
> >>
> >> http://www.parashift.com/c++-faq-lite/mixing-c-and-cpp.html
> >
> > These should really be added in the C++ application using the C headers.
> 
> I suppose it's a matter of taste as I believe that the headers should
> simply work with '#include <dvdnav/dvdnav.h>' from either C or C++.
> Not that big of a deal either way, but it seems that the convention is
> to add it to your C headers:
> 
> $ grep -rl 'extern "C"' /usr/include | wc -l
> 1897

They clearly seem to be in the minority here:

silver:~ $ find /usr/include -name '*.h' | wc -l
4754
silver:~ $ grep -rl 'extern "C"' /usr/include | wc -l
374

Diego